Skip to content

Commit caaf1a6

Browse files
authored
fix: menu order. Bump version. Plugin dependency management (#157)
* fix: menu order. Bump version. Plugin dependency management * fix: lint * fix: WP version in pipeline
1 parent 3cb6013 commit caaf1a6

File tree

4 files changed

+15
-32
lines changed

4 files changed

+15
-32
lines changed

.github/workflows/standards-and-test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@ jobs:
1616
matrix:
1717
php: [8.1, 8.2]
1818
os: [ubuntu-20.04]
19-
wordpress: [6.4.3, latest]
19+
wordpress: ['6.5', latest]
2020
include:
2121
- experimental: true
2222
- experimental: false
2323
php: 8.1
24-
wordpress: 6.4.3
24+
wordpress: '6.5'
2525

2626
name: PHPUnit - ${{ matrix.php }} - WP ${{ matrix.wordpress }}
2727

README.md

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
Contributors: conner_bw, greatislander
44
Tags: pressbooks, sso, cas
5-
Requires at least: 6.4.3
6-
Tested up to: 6.4.3
7-
Stable tag: 2.3.2
5+
Requires at least: 6.5
6+
Tested up to: 6.5
7+
Stable tag: 2.4.0
88
License: GPLv3 or later
99
License URI: https://www.gnu.org/licenses/gpl-3.0.html
1010

@@ -50,6 +50,11 @@ Because this plugin uses the fabulous [apereo/phpCAS](https://github.com/apereo/
5050
![Pressbooks CAS Administration.](screenshot-1.png)
5151

5252
## Changelog
53+
### 2.4.0
54+
55+
* See: https://github.com/pressbooks/pressbooks-cas-sso/releases/tag/2.4.0
56+
* Full release history available at: https://github.com/pressbooks/pressbooks-cas-sso/releases
57+
5358
### 2.3.2
5459

5560
* See: https://github.com/pressbooks/pressbooks-cas-sso/releases/tag/2.3.2

inc/class-admin.php

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -28,20 +28,10 @@ static public function init() {
2828
static public function hooks( Admin $obj ) {
2929
load_plugin_textdomain( 'pressbooks-cas-sso', false, 'pressbooks-cas-sso/languages/' );
3030

31-
add_action( 'network_admin_menu', [ $obj, 'addMenu' ] );
31+
add_action( 'network_admin_menu', [ $obj, 'addMenu' ], 999 );
3232
}
3333

34-
/**
35-
*
36-
*/
37-
public function __construct() {
38-
39-
}
40-
41-
/**
42-
*
43-
*/
44-
public function addMenu() {
34+
public function addMenu(): void {
4535
$parent_slug = \Pressbooks\Admin\Dashboard\init_network_integrations_menu();
4636

4737
add_submenu_page(

pressbooks-cas-sso.php

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,10 @@
55
* GitHub Plugin URI: pressbooks/pressbooks-cas-sso
66
* Release Asset: true
77
* Description: CAS Single Sign-On integration for Pressbooks.
8-
* Version: 2.3.2
8+
* Version: 2.4.0
99
* Requires PHP: 8.1
10+
* Requires at least: 6.5
11+
* Requires Plugins: pressbooks
1012
* Author: Pressbooks (Book Oven Inc.)
1113
* Author URI: https://pressbooks.org
1214
* License: GPL v3 or later
@@ -15,20 +17,6 @@
1517
* Network: True
1618
*/
1719

18-
// -------------------------------------------------------------------------------------------------------------------
19-
// Check requirements
20-
// -------------------------------------------------------------------------------------------------------------------
21-
if ( ! function_exists( 'pb_meets_minimum_requirements' ) && ! @include_once( WP_PLUGIN_DIR . '/pressbooks/compatibility.php' ) ) { // @codingStandardsIgnoreLine
22-
add_action(
23-
'admin_notices', function () {
24-
echo '<div id="message" role="alert" class="error fade"><p>' . __( 'Cannot find Pressbooks install.', 'pressbooks-cas-sso' ) . '</p></div>';
25-
}
26-
);
27-
return;
28-
} elseif ( ! pb_meets_minimum_requirements() ) {
29-
return;
30-
}
31-
3220
// -------------------------------------------------------------------------------------------------------------------
3321
// Class autoloader
3422
// -------------------------------------------------------------------------------------------------------------------

0 commit comments

Comments
 (0)