You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a follow up to this GitHub ticket: #700 (comment) - We currently have a resizer script that dynamically resizes YouTube and Vimeo embeds so that they do not exceed the width of their parent containers:
However, as per the followup comment on the GitHub ticket above, other types of activities embedded via oEmbed (like PhetSims) or iframe do not have dynamic resizing rules which apply to them. In particular, these embedded elements exceed the width of their container when inserted inside of various textbox divs.
SteelWagstaff
changed the title
oEmbed resizing only works for YouTube/Vimeo links
oEmbed / iFrame resizing only works for YouTube/Vimeo links
Dec 10, 2020
Description
This was requested through this Zendesk ticket (for internal purposes). See also https://pressbooks.zendesk.com/agent/tickets/3163
This is a follow up to this GitHub ticket: #700 (comment) - We currently have a resizer script that dynamically resizes YouTube and Vimeo embeds so that they do not exceed the width of their parent containers:
pressbooks-book/assets/src/scripts/routes/single.js
Line 118 in 49da8be
However, as per the followup comment on the GitHub ticket above, other types of activities embedded via oEmbed (like PhetSims) or iframe do not have dynamic resizing rules which apply to them. In particular, these embedded elements exceed the width of their container when inserted inside of various textbox divs.
Steps to Reproduce
Expected behavior: Should size properly, and stay in the bounds of the textbox.
Actual behavior: oEmbeds in textboxes size as if they are outside of the textbox (embeds exceed the borders of the textbox.)
The text was updated successfully, but these errors were encountered: