Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloned book does not clone over images which are larger (in pixels) than the original upload #707

Open
4 tasks done
pb-amy opened this issue Aug 10, 2020 · 0 comments
Open
4 tasks done

Comments

@pb-amy
Copy link

pb-amy commented Aug 10, 2020

Prerequisites

Description

When an image is added and is extended larger than the original copy (pixels are larger), when you clone a copy of the book, this image is no longer visible in the cloned book. The HTML clones over, but the image itself does not show (either in the visual editor or Preview). The image does exist in the book, but as its original size at time of upload in the original copy.

We think that this is happening because the book cannot render an image that is larger than the original picture. The HTML for the image includes the pixels; when pixels are removed, the image shows, meaning that the image itself is stored, but that particular size is not, because the book cannot stretch the image past the original.

This bug is from this ticket (for reference): https://pressbooks.zendesk.com/agent/tickets/1559

This book was cloned from an original (a draft). In the clone, some of the images are missing.

Here are three examples:

  1. Original -> clone
  2. Original -> clone
  3. Original -> clone

Let's take the first example. In the cloned copy, the HTML for the image is there along with the size:
Screen Shot 2020-08-10 at 4 58 02 PM

However, in the visual editor, the image does not render:
Screen Shot 2020-08-10 at 4 58 18 PM

Steps to Reproduce

  1. Upload an image, and change to a size larger than the original image uploaded
  2. Clone the book
  3. Check image in cloned book (on the book itself, and then in the editor)

Expected behavior: Book should have cloned over an image (either the larger size from the original copy, OR the image of the original size at max capacity)

Actual behavior: Image 'clones over' in the sense that the HTML shows, indicating that the image is technically 'there', but the image itself does not show.

System Information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant