Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwanted info warnings for EPUB exports when using 'Ancient Greek' #1151

Closed
SteelWagstaff opened this issue Feb 17, 2023 · 2 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@SteelWagstaff
Copy link
Member

When I add support for Ancient Greek to my book through theme options, Pressbooks imports two font families (GFS Neohellenic and SBL Greek): https://github.com/pressbooks/pressbooks-book/blob/dev/assets/book/typography/styles/_fonts-grc.scss

See https://github.com/pressbooks/pressbooks-book/blob/dev/assets/book/typography/styles/_GFSNeohellenicFont.scss + https://github.com/pressbooks/pressbooks-book/blob/dev/assets/book/typography/styles/_SBLGreekFont.scss

When I produce EPUB exports, I get unwanted info warnings about the GFSNeohellenic font:
INFO(CSS-007): /srv/www/dev.pressbooks.network/releases/20230216165602/web/app/uploads/sites/3/pressbooks/exports/Test-Shape-Shifter-1676655539.epub/EPUB/mcluhan.css(30,3): Font-face reference "EPUB/assets/GFSNeohellenic.ttf" refers to non-standard font type "application/x-empty".

This appears related to an issue recently fixed by Ricardo: pressbooks/pressbooks#3141 (#1119). I don't know why this particular font has the font type application/x-empty instead of `application/font/sfnt

To reproduce:

  1. Add 'Ancient Greek' to the 'Language & Script Support' option in McLuhan's global theme options
    Screenshot from 2023-02-17 10-01-46
  2. Turn on export notifications in Settings -> Export
    Screenshot from 2023-02-17 10-02-53
  3. Generate an EPUB export and observe the INFO warnings in the email
    Screenshot from 2023-02-17 10-03-26
@SteelWagstaff SteelWagstaff added the bug Something isn't working label Feb 17, 2023
@SteelWagstaff
Copy link
Member Author

Found the reason -- the font files for GFS Neohellenic are in fact empty files! Same is true for Mono Font. Fixing with a PR shortly.

@SteelWagstaff
Copy link
Member Author

Works as expected on dev networks. Ready for deploy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants