-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contact class lacks enough specificity #456
Comments
@cmurtagh and @tw77 -- this came up in our support checkin today. I've submitted a PR that I think should fix it by adding an additional selector to the rule which targets the
|
* fix: add additional selector to contact class Fix for #456 * chore: add built CSS
PR Merged. @arzola I guess this means a new release of Aldine. Does this happen automagically, or do we need to trigger something manually? |
Yes It cut a new release but it should be available for testing on dev right now |
I have a couple more PRs I'm hoping to open for Aldine in next week or so, if you want to hold off on cutting the new release? |
sure @SteelWagstaff we can wait to release #472 |
The CSS for Aldine has a rule that targets the
.contact
class in order to style the contact form designed to go on the home page:pressbooks-aldine/assets/styles/components/_forms.scss
Lines 109 to 117 in 47ec185
If a user creates a page with the title (& permalink) of 'Contact' the body element for the page itself also receives a
.contact
class, resulting in flex styling and padding being applied to the page. It can be overridden, but a better solution would be to add additional specification to the.contact
class designed to target just the contact form and not other elements which may happen to have this class applied. I recommend using#page
The text was updated successfully, but these errors were encountered: