Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Books should inherit site icon from network #199

Open
SteelWagstaff opened this issue Nov 23, 2019 · 1 comment
Open

Books should inherit site icon from network #199

SteelWagstaff opened this issue Nov 23, 2019 · 1 comment
Assignees
@SteelWagstaff
Labels
bug Something isn't working root network appearance
Milestone
Pressbooks Aldine...

Comments

@SteelWagstaff
Copy link
Member

SteelWagstaff commented Nov 23, 2019 •
edited
Loading

If a site icon is set in the root theme, books should inherit it. If not set, they should fall back to PB favicon.
Current behaviour, as seen on integrations:

Network root: https://integrations.pressbooks.network/
Screenshot from 2022-08-03 07-15-38

Sample book: https://integrations.pressbooks.network/oersourcebook/
Screenshot from 2022-08-03 07-15-19

Maybe this belongs in pressbooks-book?
@SteelWagstaff SteelWagstaff added bug Something isn't working root network appearance labels Nov 23, 2019
@SteelWagstaff SteelWagstaff added this to the Pressbooks Aldine 1.10.0 milestone Jun 3, 2021
@SteelWagstaff SteelWagstaff self-assigned this Jul 29, 2022
@MichSpieler
Copy link

A network manager expressed strong interest in this here: Ticket (for internal reference)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SteelWagstaff SteelWagstaff

Labels
bug Something isn't working root network appearance
Projects
None yet
Milestone
Pressbooks Aldine 1.10.0
Development

No branches or pull requests
2 participants
@SteelWagstaff @MichSpieler