Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling / Removing Twitter link on Pressbooks sites #500

Open
kylemackie opened this issue Aug 15, 2024 · 6 comments
Open

Disabling / Removing Twitter link on Pressbooks sites #500

kylemackie opened this issue Aug 15, 2024 · 6 comments
Assignees

Comments

@kylemackie
Copy link

Feature Description

Is there a way to get rid of the Twitter icon (and share to Twitter functionality on Pressbooks?

Feature Use Case

a) a prof I'm working with doesn't want to have their work shared to Twitter,
b) it's not Twitter anymore, and
c) the platform ain't what it used to be and maybe we don't want to align ourselves with it.

Other Notes

@cmurtagh
Copy link

Thank you @kylemackie, we're looking into this.

@cmurtagh
Copy link

Hey team! Please add your planning poker estimate with Zenhub @arzola @fdalcin @ho-man-chan @richard015ar

@jcurtis-pressbooks
Copy link

Tech Team: This type of issue needs input from the Marketing Team before we implement it. We get a lot of regular social media mentions on X because of that link. A lot of people still choose to use the X platform and authors may appreciate the visibility their books get when readers share using that social media link. Our preferred solution would be 1) Change out the outdated Twitter icon for the current X icon, and 2) Allow book admins to choose whether they want the icon to appear in their book.

Please reach out to the Marketing Team with any questions about this item.

@cmurtagh
Copy link

cmurtagh commented Oct 6, 2024

  1. Change out the outdated Twitter icon for the current X icon, and

Noted. Thank you.

  1. Allow book admins to choose whether they want the icon to appear in their book.

We had discussed this, and this is what we had assumed as well.

Please reach out to the Marketing Team with any questions about this item.

We will talk with them before implementing any changes.

@SteelWagstaff
Copy link
Member

@tw77 I believe this is ready for testing. Feel free to close as you see fit?

@tw77 tw77 self-assigned this Jan 2, 2025
@tw77
Copy link

tw77 commented Jan 2, 2025

Just tested this out on dev. I notice the default Social Media Options are removed from the landing pages of existing dev network books until I save changes in a book's Appearance > Theme Options > Web Options page. Upon saving, the options appear on the landing page for that particular book. The options themselves work as expected, but that extra step (options not appearing anymore until changes are manually saved) is unexpected.

@arzola is there any way we'd be able to release this change while including the default Social Media Options on book landing pages from the get go, rather than requiring this step for each book, or would that require modifying the code?

@tw77 tw77 removed their assignment Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants