From 822e025008192176c730292ccdf3172ebf178f68 Mon Sep 17 00:00:00 2001
From: Felipe Dalcin <felipe.sdalcin@gmail.com>
Date: Wed, 20 Jul 2022 13:40:10 -0400
Subject: [PATCH 1/2] chore: update rule set

---
 Pressbooks/ruleset.xml | 8 ++++++++
 composer.json          | 7 ++++++-
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/Pressbooks/ruleset.xml b/Pressbooks/ruleset.xml
index 25b1938..5b3c788 100644
--- a/Pressbooks/ruleset.xml
+++ b/Pressbooks/ruleset.xml
@@ -18,6 +18,9 @@
         <!-- Disable rules Pressbooks disagrees with: -->
         <exclude name="WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid"/>
         <exclude name="WordPress.NamingConventions.ValidVariableName.PropertyNotSnakeCase"/>
+        <exclude name="Squiz.Commenting"/>
+        <exclude name="Generic.Commenting.DocComment"/>
+        <exclude name="WordPress.NamingConventions.ValidVariableName.PropertyNotSnakeCase"/>
         <exclude name="WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase"/>
         <exclude name="WordPress.PHP.DiscouragedPHPFunctions.system_calls_exec"/>
         <exclude name="WordPress.PHP.DiscouragedPHPFunctions.runtime_configuration_ini_set"/>
@@ -30,10 +33,15 @@
     <rule ref="PSR1.Methods.CamelCapsMethodName"/>
     <!-- Disable Side Effects rule for cron scripts -->
     <rule ref="PSR1.Files.SideEffects">
+        <exclude-pattern>/*.php</exclude-pattern>
         <exclude-pattern>/bin/*</exclude-pattern>
     </rule>
+    <rule ref="HM.Files.NamespaceDirectoryName.NoIncDirectory">
+        <exclude-pattern>/bin/**/*</exclude-pattern>
+    </rule>
     <!-- Disable Namespaced Functions for cron scripts -->
     <rule ref="HM.Functions.NamespacedFunctions">
         <exclude-pattern>/bin/*</exclude-pattern>
     </rule>
+    <rule ref="PHPCompatibility"/>
 </ruleset>
diff --git a/composer.json b/composer.json
index ac2975e..3d3ca86 100644
--- a/composer.json
+++ b/composer.json
@@ -7,5 +7,10 @@
     },
     "require-dev": {
         "phpunit/phpunit": "^9.5"
+    },
+    "config": {
+        "allow-plugins": {
+            "dealerdirect/phpcodesniffer-composer-installer": true
+        }
     }
-}
\ No newline at end of file
+}

From 98f7b6c9b4b77c371c0ffc7615b338dd4548aa29 Mon Sep 17 00:00:00 2001
From: Felipe Dalcin <felipe.sdalcin@gmail.com>
Date: Wed, 20 Jul 2022 13:45:11 -0400
Subject: [PATCH 2/2] chore: update rule set

---
 Pressbooks/ruleset.xml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Pressbooks/ruleset.xml b/Pressbooks/ruleset.xml
index 5b3c788..53144f1 100644
--- a/Pressbooks/ruleset.xml
+++ b/Pressbooks/ruleset.xml
@@ -12,6 +12,7 @@
     <arg value="s"/>
     <!-- Use HM Coding Standards -->
     <rule ref="vendor/humanmade/coding-standards">
+        <!-- TODO sort rules by alphabetical order -->
         <!-- Disable rules Pressbooks overrides -->
         <exclude name="HM.Security"/>
         <exclude name="WordPress.Security.NonceVerification"/>
@@ -27,6 +28,9 @@
         <exclude name="WordPress.PHP.DiscouragedPHPFunctions.runtime_configuration_putenv"/>
         <exclude name="WordPress.PHP.DevelopmentFunctions.error_log_trigger_error"/>
         <exclude name="Generic.Formatting.MultipleStatementAlignment.NotSameWarning"/>
+
+        <!-- TODO this is temporary, rule fails because WPCS and Coding Standards don't fully support PHP 8 yet -->
+        <exclude name="Pressbooks.Security.EscapeOutput.OutputNotEscaped" />
     </rule>
     <!-- Re-enable PSR rules Pressbooks agrees with -->
     <rule ref="Generic.NamingConventions.UpperCaseConstantName"/>