Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposure option YML data #43

Open
dweaver33 opened this issue Aug 16, 2022 · 2 comments
Open

Exposure option YML data #43

dweaver33 opened this issue Aug 16, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dweaver33
Copy link

When using the exposures option, some of the data is missing or lacks a way to control content.

As you can see in the example file below, I have the following issues:

  1. Email is missing
  2. Unable to change the following fields:
  • Type
  • Maturity
  • Description

Example exposure file:

version: 2
exposures:
- name: Number of Customers per Day [chart]
  type: analysis
  maturity: low
  url: https://*********.app.preset.io/superset/explore/?form_data=********
  description: ''
  depends_on:
  - ref('ref_contacts')
  owner:
    name: Dustin Weaver
    email: unknown
- name: Customer Dashboard [dashboard]
  type: dashboard
  maturity: low
  url: https://**********.app.preset.io/superset/dashboard/9/
  description: ''
  depends_on:
  - ref('ref_contacts')
  owner:
    name: Dustin Weaver
    email: unknown
@betodealmeida
Copy link
Member

betodealmeida commented Aug 17, 2022

Hi, Dustin!

How do you see this working? Adding the email is doable but not straightforward, since requires changing the existing APIs in Superset to return the information, or doing additional API calls. But I'm not sure how to change type/maturity/description.

Right now charts are mapped to analysis, and dashboards to dashboard. If a dashboard is published the maturity is exported as high; same if a chart is certified. If we want to allow the user to override that behavior the only way I can see is by having them add metadata to the "extra" field, something like:

dbt:
    type: XXX
    description: YYY
    maturity: high

We could also do that for email as a workaround.

For description we could potentially add the field to dashboards and charts, and use that, but it would require some design work.

@dweaver33
Copy link
Author

Ah, ok, I didn't know that's how the maturity field worked. That makes sense.

As for the email and description, I think these would be super useful for someone browsing the dbt docs site.

@betodealmeida betodealmeida added enhancement New feature or request good first issue Good for newcomers labels Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants