Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbt-core sync] Model's alias has not been process #248

Open
phongnt1809 opened this issue Oct 23, 2023 · 8 comments
Open

[dbt-core sync] Model's alias has not been process #248

phongnt1809 opened this issue Oct 23, 2023 · 8 comments

Comments

@phongnt1809
Copy link

No description provided.

@Vitor-Avila
Copy link
Contributor

Hey @phongnt1809,

Could you provide more details about this issue? The CLI is supposed to handle the model alias #192.

Let me know if you're still facing this issue.

Thanks!

@phongnt1809
Copy link
Author

Hi @Vitor-Avila ,
Pull request has been created #249 for a long time.

@Vitor-Avila
Copy link
Contributor

Thanks for the update, @phongnt1809. I'm afraid that due to license restrictions, we're currently not able to accept/merge contributions from outside of Preset. I'll take a look on this scenario and see if we can address this issue. Thanks!

@Vitor-Avila
Copy link
Contributor

@phongnt1809 following up on this issue -- we recently implemented a CLA flow in this repo that allows us to accept external contributions. Would you like to wrap up your PR to contribute your change, or would you prefer if I take over? I believe your proposed solution makes sense, it's just missing a coverage test (happy to help with that as well). You would just need to go through signing the CLA in that PR.

@phongnt1809
Copy link
Author

@Vitor-Avila please help to provide coverage tests. Many thanks

@Vitor-Avila
Copy link
Contributor

@phongnt1809 sure! I would just need you to sign the CLA in that PR, otherwise we won't be able to merge it. Let me know if you're not able to and I'll start a new branch/PR

@Vitor-Avila
Copy link
Contributor

hey @phongnt1809 following up on this issue. Could you please sign the CLA in your original PR so I can contribute the tests and we can have it merged? Thanks!

@phongnt1809
Copy link
Author

@Vitor-Avila , please help to create new branch/PR. I can not link private email to my Github account then CLA process can not be done.
Thank for your patient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants