Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vim pencil hides/removes colorcolumn #75

Open
Stratus3D opened this issue Mar 30, 2019 · 4 comments
Open

Vim pencil hides/removes colorcolumn #75

Stratus3D opened this issue Mar 30, 2019 · 4 comments
Labels

Comments

@Stratus3D
Copy link

In my vimrc I have:

set colorcolumn=80,120

Without vim-pencil turned on I see columns 80 and 120 highlighted as I would expect:
Screenshot from 2019-03-29 21-49-17

But, after running :call pencil#init() the highlighting on the columns disappears:
Screenshot from 2019-03-29 21-50-18

I can manually run :set colorcolumn=80,120 to restore the columns, but I'd rather not have to do that every time. In my vimrc I have:

autocmd FileType text,mkd.markdown,markdown,mkd call pencil#init()

But if I try setting colorcolum after pencil#init() it doesn't work:

autocmd FileType text,mkd.markdown,markdown,mkd call set colorcolumn=80,120

Any idea what I should do to ensure colorcolumns are always shown without manual intervention? Ideally it would be nice if vim-pencil did not affect them at all. Happy to contribute if there is something in vim-pencil that needs to be changed to accommodate this.

@alerque
Copy link
Member

alerque commented Nov 16, 2019

This appears to be hard coded here:

https://github.com/reedes/vim-pencil/blob/236380f1afcc1df10ae78cbf2c6e958d29183eaa/autoload/pencil.vim#L266-L268

The logic seems to be that because there are extra characters added an the start of wrapped lines the color column does not actually correspond to that column in the actual text.

We could easily add some sort of preference toggle to not disable this, but before we do that maybe you can give some input on when this would be useful. Perhaps only disabling it in soft wrap mode and letting it alone in hard wrap mode would make sense. Thoughts?

@alerque alerque added the bug label Nov 16, 2019
@Stratus3D
Copy link
Author

@alerque if it doesn't align as expected, would it be feasible to figure out the correct offset, and then adjust colorcolumn as necessary?

@alerque
Copy link
Member

alerque commented Nov 27, 2019

As far as I know, no. The colorcolumn is set at the buffer/pane level and the problem is some individual lines don't align with their peers. I've never seen a "ragged" color column. I suppose it might be possible if you want to look into it, but my guess is it's going to be all or nothing.

@Stratus3D
Copy link
Author

I ended up solving by using the Goyo callbacks to toggle vim-pencil - Stratus3D/dotfiles@7b56573

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants