Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When de-identifying multiple files, don't re-prompt for file location over and over #1

Open
mrueschman opened this issue Jun 7, 2022 · 3 comments
Assignees

Comments

@mrueschman
Copy link

hat tip to Aditya M, who is assisting me from Texas on a project and using the de-identification tool.

OS: Windows (maybe it applies to other platforms as well)

The use case is to de-identify 100s of EDFs at once. User can select multiple EDFs, choose to save a copy (or not), and then the user is prompted to choose a file path to save the new EDF. At that point the user waits a few seconds for the first EDF to be re-written, after which the prompt for a file path comes up again. Hence, the user has to provide a lot of inputs (click to confirm file path) over a long period of time as each file gets re-written then the next one is queued up.

In this case, the user expected the program to simply use the first file path indicated as the output location for the entire batch of selected files. After confirming the path the user could "set it and forget it", walk away, and come back later on to a full batch of de-identified EDFs.

Thanks for the tool!

@thpossidente thpossidente self-assigned this Jun 8, 2022
@thpossidente
Copy link
Contributor

Thank you for bringing this issue to our attention!

The bug should be fixed now, I moved the prompt for specifying the file path outside the loop that goes through each edf. This issue should not effect the function versions of the edf deidentification code, but will effect the GUI apps we have for Windows, Mac, and Linux.

So far I have rebuilt the Windows GUI app with the bug fix, so that should be working now. I tested it successfully on my machine but would be grateful for confirmation from you that it is working as expected.

I am now working on updating the Linux and Mac versions so I will keep this issue open until those have been updated as well.

@mrueschman
Copy link
Author

Thanks! I gave the new Windows GUI tool a go and it worked as expected when de-identifying in batch.

@thpossidente
Copy link
Contributor

Windows and Linux GUI applications have this issue fixed, but we still need to remake the application for Mac

@thpossidente thpossidente reopened this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants