-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MACOSX_DEPLOYMENT_TARGET
does not work with c_stdlib_version
set in the build of a package for MacOS
#1117
Comments
Maybe @h-vetinari can comment on wether we need to set both values or if one should be enough. I am not sure! |
I believe you need to set both. But I am verifying with @h-vetinari and others. Thanks for testing! |
No, it should be enough to set just c_stdlib_version. We have logic in smithy that will still populate both values in the variant config though, because the CI setup still relies on MACOSX_DEPLOYMENT_TARGET. We did update the logic in staged-recipes as well (which isn't using the general ci setup), I'd have to take a look what goes wrong there |
Did you open a PR for this already? I cannot find it on https://github.com/conda-forge/staged-recipes. It's possible that local builds are missing the logic I mentioned, but it should definitely be there for the actual CI runs. |
I've had opened conda-forge/staged-recipes#27710, but changed to |
I think I understand what happens:
|
Even when I used |
Yes, with |
I see.
This means the problem ie fixed now? |
It's not fixed yet. We either need to support |
I encountered an issue where the build of a package for MacOS failed because
MACOSX_DEPLOYMENT_TARGET
was not set to the same version, even thoughc_stdlib_version
was set in the conda_build_config.yaml.conda-forge recipe I used
I don't know exactly why, but is this a kind of bug?
The text was updated successfully, but these errors were encountered: