Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert Jinja variables when evaluating script for cache (and tests?) #1068

Open
wolfv opened this issue Sep 25, 2024 · 1 comment
Open

Insert Jinja variables when evaluating script for cache (and tests?) #1068

wolfv opened this issue Sep 25, 2024 · 1 comment
Assignees

Comments

@wolfv
Copy link
Member

wolfv commented Sep 25, 2024

Small oversight in #894 where we don't inject the proper Jinja context when rendering these sections.

@wolfv wolfv self-assigned this Oct 7, 2024
@wolfv
Copy link
Member Author

wolfv commented Oct 7, 2024

This is slightly tricky, because we are not guaranteed that the rendered recipe is available when testing (users can say that they do not want to include the recipe).

We might have to copy the (evaluated) context inside of the test JSON so we can use it for evaluation, or we try to do some half-evaluation because we would like to render at run time with regards to the host_platform that we are running on, potentially.

We also want to inject the PREFIX, PYTHON and other variables that are dependent on the runtime evaluation of the script.

Later on we would also like to defer the evaluation of the dependencies (as planned, but not yet done). For that we also definitely need selection on target_platform and the like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant