Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] when zoomed do not cut off lines #307

Open
lemikhovalex opened this issue Jun 5, 2024 · 3 comments
Open

[Request] when zoomed do not cut off lines #307

lemikhovalex opened this issue Jun 5, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@lemikhovalex
Copy link

I found that once the user zooms and resampling is disabled the line un the frame is ended. It is counter intuitive as in fact there are more dots on the graph outside the box.
image

I suggest to show user dots next to the boundaries of the box.

@lemikhovalex
Copy link
Author

PR

@jonasvdd
Copy link
Member

jonasvdd commented Mar 6, 2025

I'm still not entirely convinced of the added value of this change. While I can see how it might be useful when fully zoomed in—where you already know there are surrounding points—beyond that specific case, its benefits seem limited to me.

So please, go ahead and try to convince me! :)

@jonasvdd
Copy link
Member

jonasvdd commented Mar 6, 2025

Anyway, I rebased the code (to assess compliance with current tests) and went along fixing the tests in #343

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants