Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize heading levels for bid and analytics adapters #5358

Open
bretg opened this issue May 29, 2024 · 0 comments
Open

Normalize heading levels for bid and analytics adapters #5358

bretg opened this issue May 29, 2024 · 0 comments
Assignees

Comments

@bretg
Copy link
Contributor

bretg commented May 29, 2024

For both bid adapters and analytics adapters: there are instances where individual adapters are using incorrect markdown heading levels. The layout templates assume certain levels are present in the content provided by the contributor:

The bidder layout wraps the content in H3, so contributor MD files should use H3, H4, H5, ...
The Analytics adapter layout wraps the content in H3, so contributor MD files should use H3, H4, H5, ...

There's room to discuss how the layouts work, which in both cases is:

                <h3>Features</h3>
                {{content}}
@muuki88 muuki88 self-assigned this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants