Rubicon: Update segtax logic #4224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 10, 2024 20:49
…ax-logic # Conflicts: # go.sum
…ax-logic # Conflicts: # adapters/rubicon/rubicon.go
…ax-logic # Conflicts: # go.mod
|
Reverting reverted PR: #3915 |
Code coverage summaryNote:
rubiconRefer here for heat map coverage report |
|
This error again... But I found the reason: since |
CTMBNara
commented
Feb 19, 2025
go.sum
Outdated
Comment on lines
167
to
168
| github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3 h1:zN2lZNZRflqFyxVaTIU61KNKQ9C0055u9CAfpmqUvo4= | ||
| github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3/go.mod h1:nPpo7qLxd6XL3hWJG/O60sR8ZKfMCiIoNap5GvD12KU= |
There was a problem hiding this comment.
Can I safely delete these lines? The editor told me "The file should not be edited as it's intended to be used by Go tools only." XD
There was a problem hiding this comment.
You can safely remove them since you added them as part of this change so they aren't on master. You can also run go mod tidy and that should remove just those two lines as I just tried it.
Looking at the failed test, isn't |
|
@bsardo Yes, and it's there, but it's not shown in the diff for some reason. You can check it yourself if you try to log the outcoming request. It will contain all the values but in different order |
Code coverage summaryNote:
rubiconRefer here for heat map coverage report |
Code coverage summaryNote:
rubiconRefer here for heat map coverage report |
Code coverage summaryNote:
rubiconRefer here for heat map coverage report |
|
I talked to Bret and we agreed to simplify the logic. Related pr in Java: prebid/prebid-server-java#3796 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.