Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aidem: Support only banner and video formats #4203

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dsabaras-aidem
Copy link

Aidem is supporting only banner and video formats, so all the other format impressions should be filtered out and in case there are no banner or video format impressions aidem should not receive any bid requests.

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 5e989bb

aidem

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/aidem/aidem.go:22:	MakeRequests		82.4%
github.com/prebid/prebid-server/v3/adapters/aidem/aidem.go:59:	MakeBids		94.7%
github.com/prebid/prebid-server/v3/adapters/aidem/aidem.go:105:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/aidem/aidem.go:117:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/aidem/aidem.go:128:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v3/adapters/aidem/aidem.go:144:	getSupportedImps	100.0%
github.com/prebid/prebid-server/v3/adapters/aidem/aidem.go:160:	buildEndpointURL	100.0%
total:								(statements)		90.2%

@bsardo bsardo added the adapter label Feb 13, 2025
@bsardo bsardo changed the title Aidem: support for only banner and video formats Aidem: Support only banner and video formats Feb 13, 2025
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 5675413

aidem

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/aidem/aidem.go:22:	MakeRequests		82.4%
github.com/prebid/prebid-server/v3/adapters/aidem/aidem.go:59:	MakeBids		94.7%
github.com/prebid/prebid-server/v3/adapters/aidem/aidem.go:105:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/aidem/aidem.go:117:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/aidem/aidem.go:128:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v3/adapters/aidem/aidem.go:144:	getSupportedImps	100.0%
github.com/prebid/prebid-server/v3/adapters/aidem/aidem.go:160:	buildEndpointURL	100.0%
total:								(statements)		90.2%

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, b1037f3

aidem

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/aidem/aidem.go:22:	MakeRequests		75.0%
github.com/prebid/prebid-server/v3/adapters/aidem/aidem.go:51:	MakeBids		94.7%
github.com/prebid/prebid-server/v3/adapters/aidem/aidem.go:97:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/aidem/aidem.go:109:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/aidem/aidem.go:120:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v3/adapters/aidem/aidem.go:137:	buildEndpointURL	100.0%
total:								(statements)		87.8%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants