Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Adapter: Netaddiction - Admatic alias #4201

Open
wants to merge 77 commits into
base: master
Choose a base branch
from

Conversation

bakicam
Copy link
Contributor

@bakicam bakicam commented Feb 13, 2025

@guscarreon
Copy link
Contributor

In your docs PR AdMatic: documenting admaticde and netaddiction alias #5639, monetixads.yaml and pixad.yaml don't seem to have been included. Can we open a separate docs PR to document them? In said AdMatic: documenting admaticde and netaddiction alias #5639 PR, is admaticde another alias that you meant to code in our repo? I see an admatic adapter in our adapters/ directory but I don't see admaticde. Can you clarify?

@bsardo
Copy link
Collaborator

bsardo commented Feb 24, 2025

@bakicam can you please open a separate PR for each alias? Also please ensure that you have a docs PR for each.

Also admaticde is not going to work. We have a rule where the first six characters of an adapter name need to be unique and so this conflicts with admatic. Please consider another name.

@farukcam
Copy link
Contributor

@bsardo We had published it for the client with this PR. These are not new adapters, they are already working adapters for the client. I am sending the documentation pages below. Can you check again?

https://docs.prebid.org/dev-docs/bidders/admaticde.html
https://docs.prebid.org/dev-docs/bidders/netaddiction.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants