Support bidder-specific device data #4197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces support for bidder-specific device data. It merges bidderconfig.ortb2.device fields into request.device, with bidderconfig.ortb2.device taking precedence. Fixes prebid#4147
| } | ||
|
|
||
| return newDevice, nil | ||
| } |
There was a problem hiding this comment.
Can you please add device validation before returning it?
Logic should be the same as in func validateDevice(device *openrtb2.Device).
This function is not available here, so copying it is ok.
Also please add a unit test for this.
This commit adds device validation logic ported from endpoints/openrtb2/auction.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for bidder-specific device data.
It merges
bidderconfig.ortb2.devicefields intorequest.device, withbidderconfig.ortb2.devicetaking precedence.Fixes #4147