feat: Add ElementRef type to compat
#4557
Conversation
| export type ComponentPropsWithRef< | ||
| C extends ComponentType<any> | keyof JSXInternal.IntrinsicElements | ||
| > = C extends new ( | ||
| export type ComponentPropsWithRef<C extends ElementType> = C extends new ( |
There was a problem hiding this comment.
We didn't originally have ElementType when I added ComponentPropsWithRef but someone kiindly added it a few months ago. It's worth switching this over, helps ensure things are kept in-sync.
For comparison: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/b5dc32740d9b45d11cff9b025896dd333c795b39/types/react/index.d.ts#L1687-L1689
|
That's a great question. Will investigate further |
|
Ignoring our resolution issues for the moment, this seems to work as we need? It does produce a type error in the compat declaration file, but in 5.0 & 5.1, the user is presented with a seemingly functional & identical type. This would require Copy/pasting the shadcn examples given in the issue, there doesn't seem to be a user-facing problem, it's just that the generic doesn't satisfy. I'm not well enough informed to say whether this is a problem or not though. |
Closes #4481
For comparison: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/b5dc32740d9b45d11cff9b025896dd333c795b39/types/react/index.d.ts#L221-L235
Can confirm #4548 cleared the way for this -- like a total doofus I created a new vite project and was wildy confused to see the same old error re: can't assign
null | undefinedtoVNode<any>as I had only copied over this particular change. Eventually the issue dawned on me, copied over the new types, and it worked like a treat!