Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PreactX] No longer working with undom #1480

Closed
staydecent opened this issue Mar 29, 2019 · 2 comments
Closed

[PreactX] No longer working with undom #1480

staydecent opened this issue Mar 29, 2019 · 2 comments

Comments

@staydecent
Copy link

I've been using undom for my tests in quite a few projects. I just started exploring hooks in one of my own branches, and realized latest PreactX does not work with undom.

I took the linked fiddle from undom, and replaced the preact resource with: http://npmcdn.com/preact@next

With that as the only change, the fiddle stops working:
https://jsfiddle.net/vu3qjarw/

I'm not sure if undom needs updating to implement some DOM features that PreactX now requires, or if PreactX needs updates to the render?

Perhaps this is better suited as on issue on the undom project? If so, let me know and I can recreate it there.

Thanks!

@staydecent staydecent changed the title PreactX does not work with undom [PreactX] No longer working with undom Mar 29, 2019
@marvinhagemeister
Copy link
Member

marvinhagemeister commented Mar 30, 2019

yup this issue is better suited on the undom repo. We are very likely using some features of the DOM which undom doesn't stub out. That's hardly an issue in Preact. If you do create an issue on the undom repo, be sure to include the error message you are getting. Looking at the fiddle it seems like it doesn't use the umd bundle which is built for the browser and thus trips up over some module specific code (exports/imports).

@developit
Copy link
Member

Update if anyone runs into this: I've patched the JSFiddle to work with Preact: https://jsfiddle.net/developit/9jzyv6we/
Undom was missing .localName and .data (developit/undom#32), but the breakage was actually due to a fix JSFiddle rolled out that enabled strict mode for JS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants