Add comment-key input #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@developit any chance this can get feedback sometime? |
|
@developit Is it possible this PR could get a review? |
bacarybruno
reviewed
Jul 12, 2023
Co-authored-by: Bruno Bodian <[email protected]>
|
@developit Any chance for a review here? |
|
Closing this PR to clean up my list of open PRs. Please ping me if you'd like me to reopen the PR. |
slorber
suggested changes
Sep 26, 2024
|
@JoviDeCroock @rschristian are either of y'all able to review this PR? (Just picking the last couple folks I see reviewing and merging in this repository, hope that's okay) |
|
Thanks for the ping, I'll definitely try to take a look. Just need to figure out how to test it. |
rschristian
approved these changes
Sep 27, 2024
sarayourfriend
force-pushed
the
add/optional-comment-key
branch
from
2fc32c1
to
1b56a4a
Compare
sarayourfriend
force-pushed
the
add/optional-comment-key
branch
from
1b56a4a
to
79684ef
Compare
|
All good, thanks for the review. I've pushed changes with docs to the README and resolved the merge conflict. |
rschristian
reviewed
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #81 using the suggested implementation.
I'm not totally sure how changes to this are tested, mostly because the CI only runs the action with limited options. Open to recommendations for how to properly test this.