-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments are not stripped from compressed files #39
Comments
I opened an issue against the |
This would likely have to be an option that is disabled by default, since it requires parsing the JS. That'll be slow, right now file files aren't even loaded into memory. |
FWIW I use a fork of this action with a fork of the size plugin - necolas/compressed-size-plugin@082eb2c |
Closing, as the better solution here would be to feed the intended output into this action. If you production builds strip comments, then do that and provide the result to compressed-size here. |
JavaScript comments are not removed from the built files and contribute to reported file size. I think comments should be stripped to provide realistic data that reflects what a production build would do.
The text was updated successfully, but these errors were encountered: