Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments are not stripped from compressed files #39

Closed
necolas opened this issue Aug 28, 2020 · 4 comments
Closed

Comments are not stripped from compressed files #39

necolas opened this issue Aug 28, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@necolas
Copy link

necolas commented Aug 28, 2020

JavaScript comments are not removed from the built files and contribute to reported file size. I think comments should be stripped to provide realistic data that reflects what a production build would do.

@necolas
Copy link
Author

necolas commented Aug 28, 2020

I opened an issue against the size-plugin-core module as it looks like that is where the feature is missing - kuldeepkeshwar/size-plugin-core#8

@developit
Copy link
Member

This would likely have to be an option that is disabled by default, since it requires parsing the JS. That'll be slow, right now file files aren't even loaded into memory.

@developit developit added the enhancement New feature or request label Dec 18, 2020
@necolas
Copy link
Author

necolas commented Dec 18, 2020

FWIW I use a fork of this action with a fork of the size plugin - necolas/compressed-size-plugin@082eb2c

@rschristian
Copy link
Member

Closing, as the better solution here would be to feed the intended output into this action. If you production builds strip comments, then do that and provide the result to compressed-size here.

@rschristian rschristian closed this as not planned Won't fix, can't repro, duplicate, stale Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants