remove setting to (not) read_schema

We always need to read the schema, so now we always do.

Author: preaction

eg/meet-space/myapp.pl

@@ -68,18 +68,13 @@
 
 use Yancy::Backend::Sqlite;
 my $backend = Yancy::Backend::Sqlite->new($db);
-$backend->read_schema;
-# XXX: Should not have to read_schema on backend
 
 use Yancy::Model;
 my $db_model = Yancy::Model->new(
   backend => $backend,
   schema => \%model_schema,
 );
-
 unshift @{ $db_model->namespaces }, 'MyApp';
-# XXX: Should not have to re-read schema after adjusting namespaces
-$db_model->read_schema;
 
 use Yancy::Content;
 my $content = Yancy::Content->new(backend => $backend);

lib/Mojolicious/Plugin/Yancy.pm

@@ -184,11 +184,6 @@ sub register {
     # That allows for easier extending/replacing of them.
     # Almost everything in here should be a delegated plugin...
 
-    # New default for read_schema is on, since it mostly should be
-    # on. Any real-world database is going to be painstakingly tedious
-    # to type out in JSON schema...
-    $config->{read_schema} //= 1;
-
     # Load the model
     # XXX: This should be Yancy::Plugin::Model
     $config = { %$config };
@@ -198,7 +193,6 @@ sub register {
       $model = $class->new(
         backend => $config->{backend},
         log => $app->log,
-        ( read_schema => $config->{read_schema} )x!!exists $config->{read_schema},
         schema => $config->{schema},
       );
     }

lib/Yancy/Backend.pm

@@ -400,7 +400,7 @@ sub query_p { ... }
     my $schema = $be->read_schema;
     my $table = $be->read_schema( $table_name );
 
-Read the schema from the database tables. Returns an OpenAPI schema
+Read the schema from the database tables. Returns a JSON Schema
 ready to be merged into the user's configuration. Can be restricted
 to only a single table.
 

lib/Yancy/Backend/Dbic.pm

@@ -8,15 +8,13 @@ our $VERSION = '1.089';
     use Mojolicious::Lite;
     plugin Yancy => {
         backend => 'dbic://My::Schema/dbi:Pg:localhost',
-        read_schema => 1,
     };
 
     ### DBIx::Class::Schema object
     use Mojolicious::Lite;
     use My::Schema;
     plugin Yancy => {
         backend => { Dbic => My::Schema->connect( 'dbi:SQLite:myapp.db' ) },
-        read_schema => 1,
     };
 
     ### Arrayref
@@ -31,7 +29,6 @@ our $VERSION = '1.089';
                 { PrintError => 1 },
             ],
         },
-        read_schema => 1,
     };
 
 =head1 DESCRIPTION

lib/Yancy/Backend/Mysql.pm

@@ -8,15 +8,13 @@ our $VERSION = '1.089';
     use Mojolicious::Lite;
     plugin Yancy => {
         backend => 'mysql:///mydb',
-        read_schema => 1,
     };
 
     ### Mojo::mysql object
     use Mojolicious::Lite;
     use Mojo::mysql;
     plugin Yancy => {
         backend => { Mysql => Mojo::mysql->new( 'mysql:///mydb' ) },
-        read_schema => 1,
     };
 
     ### Hash reference
@@ -29,7 +27,6 @@ our $VERSION = '1.089';
                 password => 'b3nd3r1sgr34t',
             },
         },
-        read_schema => 1,
     };
 
 =head1 DESCRIPTION

lib/Yancy/Backend/Pg.pm

@@ -8,15 +8,13 @@ our $VERSION = '1.089';
     use Mojolicious::Lite;
     plugin Yancy => {
         backend => 'pg://user:pass@localhost/mydb',
-        read_schema => 1,
     };
 
     ### Mojo::Pg object
     use Mojolicious::Lite;
     use Mojo::Pg;
     plugin Yancy => {
         backend => { Pg => Mojo::Pg->new( 'postgres:///myapp' ) },
-        read_schema => 1,
     };
 
     ### Hashref
@@ -29,7 +27,6 @@ our $VERSION = '1.089';
                 password => 'b3nd3r1sgr34t',
             },
         },
-        read_schema => 1,
     };
 
 

lib/Yancy/Backend/Sqlite.pm

@@ -8,15 +8,13 @@ our $VERSION = '1.089';
     use Mojolicious::Lite;
     plugin Yancy => {
         backend => 'sqlite:data.db',
-        read_schema => 1,
     };
 
     ### Mojo::SQLite object
     use Mojolicious::Lite;
     use Mojo::SQLite;
     plugin Yancy => {
         backend => { Sqlite => Mojo::SQLite->new( 'sqlite:data.db' ) },
-        read_schema => 1,
     };
 
     ### Hashref
@@ -27,7 +25,6 @@ our $VERSION = '1.089';
                 dsn => 'sqlite:data.db',
             },
         },
-        read_schema => 1,
     };
 
 =head1 DESCRIPTION

lib/Yancy/Guides/Cookbook.pod

@@ -47,7 +47,7 @@ to handle the form before the final action is called.
     # Download this example: https://github.com/preaction/Yancy/tree/master/eg/cookbook/custom-filter-lite.pl
     use Mojolicious::Lite -signatures;
     # Download log.sqlite3: https://github.com/preaction/Yancy/tree/master/eg/cookbook/log.sqlite3
-    plugin Yancy => { backend => 'sqlite:log.sqlite3', read_schema => 1 };
+    plugin Yancy => { backend => 'sqlite:log.sqlite3' };
     under sub( $c ) {
         my $levels = $c->every_param( 'log_level' );
         if ( @$levels ) {
@@ -105,7 +105,6 @@ Then, we can call the action we want to end up at (in this case, the
             # Download log.db: http://github.com/preaction/Yancy/tree/master/eg/cookbook/log.sqlite3
             $self->plugin( Yancy => {
                 backend => 'sqlite:log.sqlite3',
-                read_schema => 1,
             } );
 
             $self->routes->get( '/' )->to(

lib/Yancy/Guides/Schema.pod

@@ -6,7 +6,6 @@
     use Mojolicious::Lite;
     plugin Yancy => {
         backend => 'pg://localhost/myapp',
-        read_schema => 1,
         schema => {
             users => {
                 title => 'Users',

lib/Yancy/I18N/en.pm

@@ -69,7 +69,7 @@ our %Lexicon = (
 
     # Error description used when Yancy could not find any schemas to
     # manage (HTML allowed)
-    'No Schema Configured description' => 'Please configure your data schema, or have Yancy scan your database by setting <code>read_schema =&gt; 1</code>.',
+    'No Schema Configured description' => 'Please configure your data schema.',
 
     # Error title used when Yancy could not fetch the API specification
     'Error Fetching API Spec' => 'Error Fetching API Spec',