Completion mess with existing code

[pengux]

Referring to issue prabirshrestha/asyncomplete.vim#127, upon completion it deletes existing code. Setting let g:lsp_text_edit_enabled = 0 fixes this behavior.

[0xBADDCAFE]

This issue targets like the behavior?

1. ce on normal mode to go to insert mode with erase part of word
2. <C-n> to select completion that longer than original word.
3. <Esc> and wait to dismiss popup
4. Completion deletes trailing code ( ( before resp.Body is deleted in below gif)

VIM - Vi IMproved 8.1 (2018 May 18, compiled Sep 29 2019 22:27:49)
Included patches: 1-2102
OS: Arch Linux (on WSL)
LSP Engine: golang.org/x/tools/gopls v0.1.7 (go version go1.13.3 linux/amd64)

[mnishz]

I think I got the same behavior. I'll also change g:lsp_text_edit_enabled for tentative fix. Thank you.

[mattn]

did you solve this issue?

[0xBADDCAFE]

Setting let g:lsp_text_edit_enabled = 0 prevent this, but still causes when let g:lsp_text_edit_enabled = 1 .
#597 explains further, so I think that can close this issue and continue discussion in #597 .

[mattn]

Updated textEdit behavior in recent changes. Could you please try this again?

[mnishz]

The same issue was recreated with the latest one (ed1c263) and let g:lsp_text_edit_enabled = 1.

[0xBADDCAFE]

Still causes with ed1c263 and let g:lsp_text_edit_enabled = 1 (on above environment) too.

[prabirshrestha]

Can you try the latest master again. else please provide a hello world repository with repo.

[prabirshrestha]

Also if anyone has a minimal repository with the repo that would be good.

[0xBADDCAFE]

hello world repository with repo.

I'll try it so please just a time (few day).

[hrsh7th]

@0xBADDCAFE
Could you try #637?
I re-implement CompleteDone behavior.

[0xBADDCAFE]

I tried #637 and it seems to be fixed this issue.

[mnishz]

#637 worked on my machine as well.

[prabirshrestha]

PR has been merged. Please try latest master. Thanks to those who tired and bit shoutout to @hrsh7th for the actual fix.