Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update widget_surveyor example to use it's own index or update package:corpus #31

Open
pq opened this issue Apr 7, 2021 · 2 comments
Open

update widget_surveyor example to use it's own index or update package:corpus #31

pq opened this issue Apr 7, 2021 · 2 comments
Assignees
@pq

Comments

@pq
Copy link
Owner

pq commented Apr 7, 2021

The widget example uses the index from package:corpus. In order to update (#26) we'll need to either bring package:corpus to NNBD and the latest analyzer or decouple and inline the index code.
@pq pq added this to the 1.0.0 milestone Apr 7, 2021
@pq
Copy link
Owner Author

pq commented Apr 7, 2021

See also: pq/corpus#3.

@pq pq self-assigned this Apr 7, 2021
@pq pq removed this from the 1.0.0 milestone Apr 7, 2021
@pq
Copy link
Owner Author

pq commented Apr 7, 2021

I made a provisional fix to pin the version to an older surveyor, pinned with a git ref. Not ideal but I'm not sure if this is an example we want to carry forward or if so, whether the corpus index is the desired path. For now anyway, I think we're good for 1.0 so removing this from that milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pq