Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy and Paste of Notes and Bars does not work, the selector is wrong and it drops the last thing selected #416

Open
PellTheTabber1 opened this issue Dec 4, 2022 · 1 comment
Open

Copy and Paste of Notes and Bars does not work, the selector is wrong and it drops the last thing selected #416

PellTheTabber1 opened this issue Dec 4, 2022 · 1 comment
Labels
bug C-editing
Milestone
Alpha 20

Comments

@PellTheTabber1
Copy link

PellTheTabber1 commented Dec 4, 2022 •
edited
Loading

Bug
Description
I tiried to select a barline and delete it but it selects all the stuff before it too. This is a very serious issue and I would guess it needs to be fixed right away. In the meantime, I have a suggestion for people to use as a workaround. Simply select the bar and one note to the RIGHT of the bar and then reinsert the missing note after hitting the delete key. This is a godsend of a solution that I've found as it's no longer a showstopper of a bug.

To Reproduce
Steps to reproduce the issue.

Additional Info
If applicable, add a screenshot or attach an example file that demonstrates the issue.

Version
If applicable, include your operating system (e.g. Windows 10) and which version of Power Tab Editor (e.g. Alpha 12) you are using
@cameronwhite cameronwhite added this to the Alpha 20 milestone Dec 6, 2022
@cameronwhite
Copy link
Member

I can reproduce this - selecting a bar line seems to sometimes inadvertently select all of the previous notes (the blue highlighted area), which is why they were then deleted

DontBelieveMe added a commit to DontBelieveMe/powertabeditor that referenced this issue Oct 7, 2023
@DontBelieveMe
Stop selecting barlines from also selecting all preceding notes (powe…
864678b 
…rtab#416)

This is only a partial fix for powertab#416 as barlines are still not copied,
but that seems like a separate issue :)

The bug seems to be coming from, when creating the barlines,
it was coping the staff location & changing the position index,
but not also changing the selection start index, which is still
at 0 (hence why all preceding notes are selected).

This bug manifested in a few other places as well, so also
fixed them up.
@DontBelieveMe DontBelieveMe mentioned this issue Oct 7, 2023
Merged
cameronwhite pushed a commit that referenced this issue Oct 10, 2023
@DontBelieveMe
Stop selecting barlines from also selecting all preceding notes (#416) (
5aba86b 
#453)

This is only a partial fix for #416 as barlines are still not copied,
but that seems like a separate issue :)

The bug seems to be coming from, when creating the barlines,
it was coping the staff location & changing the position index,
but not also changing the selection start index, which is still
at 0 (hence why all preceding notes are selected).

This bug manifested in a few other places as well, so also
fixed them up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug C-editing
Projects
None yet
Milestone
Alpha 20
Development

No branches or pull requests
2 participants
@cameronwhite @PellTheTabber1