Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Fret Lables #366

Open
Fieora opened this issue Jan 22, 2022 · 3 comments
Open

Custom Fret Lables #366

Fieora opened this issue Jan 22, 2022 · 3 comments

Comments

@Fieora
Copy link

Fieora commented Jan 22, 2022

Description
Allow custom fret labels (attached to instrument, player, or tuning) to allow other instruments that don't just use numbered frets/positions.

For example, shamisen players have the following:
0 -> 0
1 -> 1
2 -> 2
3 -> 3
4 -> #
5 -> 4
6 -> 5
7 -> 6
8 -> 7
9 -> 8
10 -> 9
11 -> 1b
12 -> 10
13 -> 11
14 -> 12
15 -> 13
16 -> 1#
17 -> 14
18 -> 15
19 -> 16
20 -> 17
21 -> 18

Additional context
Shamisen players would LOVE this feature, and essentially there is no tab editor that works easily for us, so this would be a killer feature.

@cameronwhite
Copy link
Member

I need to read up on shamisens :) , but at first glance this might make sense as a property of the tuning
Is each fret is still a half step?

@Fieora
Copy link
Author

Fieora commented Jan 23, 2022

I need to read up on shamisens :) , but at first glance this might make sense as a property of the tuning Is each fret is still a half step?

Yes, they are still half steps.

@cameronwhite
Copy link
Member

Thanks! Yeah I'd say this makes sense to have as part of the tuning, maybe as an enum describing the different fret labeling methods.
Then SystemRenderer::drawTabNotes() could take this into account, and to find the tuning for the note being drawn the logic would be similar to https://github.com/powertab/powertabeditor/blob/master/source/painters/stdnotationnote.cpp#L140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants