Skip to content

Replace fetch_client package with regular http #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged

Conversation

simolus3
Copy link
Contributor

@simolus3 simolus3 commented May 8, 2025

For a long time, package:http was implemented using XMLHttpRequest on the web. Since version 1.3.0 however, it has finally been migrated to fetch. Unfortunately, it called window.fetch which makes that version unavailable in workers. That has been fixed in version 1.4.0, which means that we can use an upstream BrowserClient instead of depending on fetch_client.

@simolus3 simolus3 requested a review from rkistner May 8, 2025 10:01
@simolus3 simolus3 merged commit 82c774f into main May 8, 2025
5 checks passed
@simolus3 simolus3 deleted the upstream-http branch May 8, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants