Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add telemetry events #492

Open
danschultzer opened this issue Apr 17, 2020 · 3 comments · May be fixed by #506
Open

Add telemetry events #492

danschultzer opened this issue Apr 17, 2020 · 3 comments · May be fixed by #506

Comments

@danschultzer
Copy link
Collaborator

danschultzer commented Apr 17, 2020 •
edited
Loading

This was already discussed way back in #122, but now with the Phoenix Live Dashboard announcement I think it's time to add in the telemetry events so it can easily be hooked up.

OWASP recommends logging the following:

  • Session ID creation
  • Session ID renewal
  • Session ID destruction
  • Login and logout operations
  • Privilige changes
  • Timeout expiration
  • Invalid session activities
  • Critical business operations

I think the following could be nice metrics:

  • Number of current sessions
  • Number of users signed in
  • Number of failed sign in attempts
  • Average and peak number of failed attempts per user
  • Average and peak number of sessions per user
  • Average authentication duration time

Please share if you got any suggestions for what to track 😄
@ghost
Copy link

ghost commented Apr 19, 2020

I would only add total numbers of users.

@cdvv7788
Copy link
Contributor

Registrations would be useful for this too? Or this is meant to track only sessions?
For the extensions, things like confirmed accounts could be useful too.

@danschultzer danschultzer linked a pull request Apr 27, 2020 that will close this issue
Draft
10 tasks
@danschultzer
Copy link
Collaborator Author

Registrations would be useful for this too? Or this is meant to track only sessions?

Yeah, since registrations is just collecting what exists in the DB at any certain point.

For total number of signed in users, this is great: https://ghost.jmnorlund.net/instrumenting-an-elixir-phoenix-pow-application/ (by @jmn)

@danschultzer danschultzer mentioned this issue Sep 20, 2020
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Telemetry pow-auth/pow
2 participants
@danschultzer @cdvv7788