Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCKE support? #108

Closed
spence opened this issue Oct 4, 2022 · 3 comments
Closed

PCKE support? #108

spence opened this issue Oct 4, 2022 · 3 comments

Comments

@spence
Copy link

spence commented Oct 4, 2022

I see WIP support for PKCE flows in danschultzer/ex_oauth2_provider#91.

Any thoughts on integrating PKCE into Assent?

@danschultzer
Copy link
Collaborator

danschultzer commented Feb 22, 2023

PKCE only makes sense with public clients where you can't store a client secret securely (e.g. native apps or SPA). I can't think of a situation where assent would be part of client side code?

@adamcstephens
Copy link

adamcstephens commented May 20, 2024

Any chance this could be reconsidered? Here's an argument for PKCE even for confidential clients: https://kanidm.github.io/kanidm/stable/frequently_asked_questions.html#why-is-disabling-pkce-considered-insecure

@adamcstephens
Copy link

adamcstephens commented Jul 2, 2024

Or here's another source. The IETF recommends PKCE for all clients, including web authentication. https://datatracker.ietf.org/doc/html/draft-ietf-oauth-security-topics-29#section-2.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants