Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce secret data type #1226

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Introduce secret data type #1226

wants to merge 4 commits into from

Conversation

shamasis
Copy link
Member

@shamasis shamasis commented Nov 29, 2021

Password type is essentially a string type. This is also a precursor to allow external hooks into type handling.

  • added new password type
  • reordered code in type def for cleanliness
  • tests
  • no breaking change

Edit: We are calling the data type as secret instead of password

@@ -257,6 +257,28 @@ _.assign(Variable, /** @lends Variable */ {
*/
number: Number,

/**
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block is not a change, but merely a code reorder for clean addition of new type

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #1226 (5dee7da) into develop (dbcf65b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop     #1226   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines         2161      2161           
  Branches       660       660           
=========================================
  Hits          2161      2161           
Flag Coverage Δ
unit 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/collection/variable.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbcf65b...5dee7da. Read the comment docs.

@UmedJadhav UmedJadhav changed the title Introduce password data type Introduce secret data type Dec 3, 2021
@shamasis shamasis changed the title Introduce secret data type Introduce password data type Dec 3, 2021
@shamasis shamasis changed the title Introduce password data type Introduce secret data type Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants