Skip to content

Commit 99457c4

Browse files
Addressed minor comments
1 parent 805b014 commit 99457c4

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

lib/collection/script.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,9 @@ _.assign(Script.prototype, /** @lends Script.prototype */ {
6464
*/
6565
this.type = options.type || 'text/javascript';
6666

67+
/**
68+
* @type {Object}
69+
*/
6770
this.packages = options.packages || {};
6871

6972
_.has(options, 'src') && (

test/unit/collection.test.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@ describe('Collection', function () {
2525
script: {
2626
id: 'my-script-1',
2727
type: 'text/javascript',
28-
exec: ['console.log("This doesn\'t matter");'],
29-
packages: {}
28+
exec: ['console.log("This doesn\'t matter");']
3029
}
3130
}]
3231
},

test/unit/event-list.test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ describe('EventList', function () {
1111
script: {
1212
type: 'text/javascript',
1313
exec: 'console.log("hello");',
14-
packages: [{ id: 'script-package-1', name: 'package1' }]
14+
packages: { package1: { id: 'script-package-1' } }
1515
}
1616
}];
1717

@@ -49,7 +49,7 @@ describe('EventList', function () {
4949
id: 'test-script-1',
5050
type: 'text/javascript',
5151
exec: ['console.log("hello");'],
52-
packages: { package1: { id: 'script-apckage-1' } }
52+
packages: { package1: { id: 'script-package-1' } }
5353
}
5454
}]);
5555

@@ -67,7 +67,7 @@ describe('EventList', function () {
6767
id: 'test-script-1',
6868
type: 'text/javascript',
6969
exec: ['console.log("hello");'],
70-
packages: { package1: { id: 'script-apckage-1' } }
70+
packages: { package1: { id: 'script-package-1' } }
7171
}
7272
});
7373

0 commit comments

Comments
 (0)