fix: fix possible use of unitialized memory fixes issue #99 (#100)

davecramer · web-flow · commit 05504eb4565b · 2025-03-26T10:58:08.000-04:00
diff --git a/mylog.c b/mylog.c
@@ -133,8 +133,10 @@ const char *GetExeProgramName()
 
 		for (i = 0; i < sizeof(flist) / sizeof(flist[0]); i++)
 		{
-			if (readlink(flist[i], path_name, sizeof(path_name)) > 0)
+			ssize_t len = readlink(flist[i], path_name, sizeof(path_name));
+			if (len > 0)
 			{
+				path_name[len] = '\0';
 				/* fprintf(stderr, "i=%d pathname=%s\n", i, path_name); */
 				STRCPY_FIXED(exename, po_basename(path_name));
 				break;

Original file line number	Diff line number	Diff line change
`@@ -133,8 +133,10 @@ const char *GetExeProgramName()`
`133`	`133`
`134`	`134`	`for (i = 0; i < sizeof(flist) / sizeof(flist[0]); i++)`
`135`	`135`	`{`
`136`		`- if (readlink(flist[i], path_name, sizeof(path_name)) > 0)`
	`136`	`+ ssize_t len = readlink(flist[i], path_name, sizeof(path_name));`
	`137`	`+ if (len > 0)`
`137`	`138`	`{`
	`139`	`+ path_name[len] = '\0';`
`138`	`140`	`/* fprintf(stderr, "i=%d pathname=%s\n", i, path_name); */`
`139`	`141`	`STRCPY_FIXED(exename, po_basename(path_name));`
`140`	`142`	`break;`