Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postageapp mangles Rails' mail object. Shouldn't. #12

Open
GBH opened this issue Sep 30, 2015 · 0 comments
Open

Postageapp mangles Rails' mail object. Shouldn't. #12

GBH opened this issue Sep 30, 2015 · 0 comments

Comments

@GBH
Copy link
Contributor

GBH commented Sep 30, 2015

Right now this gems hijacks most of the mail construction. This causes tons of issues with things like previews, interceptors and whatever else Rails is doing (plus comparability with other libraries that do things to email). You can bet that Rails 5 will break this gem again.

Better approach would be to let Rails construct whatever it needs and only catch mail object when there's an attempt to deliver. Then you can disassemble mail object to construct our API call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant