Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive background food consumption when greenhouse is on #316

Open
pdg137 opened this issue Jun 11, 2023 · 2 comments
Open

Excessive background food consumption when greenhouse is on #316

pdg137 opened this issue Jun 11, 2023 · 2 comments
Labels
ext. compatibility issue relates to an external mod

Comments

@pdg137
Copy link

pdg137 commented Jun 11, 2023

There's a closed issue over at KSP-RO/TacLifeSupport#112 about how background food usage is sometimes 60x too high when a SSPXr greenhouse is activated. Changing the number on this line to zero fixes it:

https://github.com/post-kerbin-mining-corporation/StationPartsExpansionRedux/blob/dev/GameData/StationPartsExpansionRedux/Patches/SSPXR-TACLS-00.cfg#L157

I don't know what the mineral siphon is for or what that number means, but there's definitely something wrong. Since TAC is apparently no longer being maintained I wonder if this can be fixed somehow in this mod.

@JadeOfMaar
Copy link
Contributor

JadeOfMaar commented Sep 21, 2023

That SSPX TAC config is mine. The reason for it existing is that the included greenhouse setup uses Minerals like non-TAC greenhouses would use USI's Fertilizer, but since TAC really doesn't care for ISRU (drilling and refining things and making better use of Waste and WasteWater) it seemed like a good idea to provide an option to extract Minerals from excess Food if the player ever decided there was too much Food.

To resolve this issue and possible others, and allow for someone to update/fix these patches conveniently, they would need to be separated and published as their own download/modlet so they aren't dragged down by being part of a huge download and its restrictive license (SSPXR).

@ChrisAdderley ChrisAdderley added the ext. compatibility issue relates to an external mod label Aug 14, 2024
@tinygrox
Copy link
Contributor

tinygrox commented Nov 3, 2024

All right then, here I put a MM patch to delete this damn Mineral Siphon for anyone who needs it:

@PART[sspx*greenhouse*]:NEEDS[TacLifeSupport,StationPartsExpansionRedux]:AFTER[StationPartsExpansionRedux]
{
    !MODULE[TacGenericConverter]:HAS[#ConverterName[Mineral?Siphon]] { }
}

Save as a .cfg file and place it in any location under your GameData.
Note that the Mineral?Siphon should be replaced with the actual string in your game's current language. In English, it just Mineral?Siphon, in Chinese it is 矿物虹吸.
For other languages, go find your language's #LOC_SSPXR_Switcher_TacGenericConverter7_ConverterName in the GameData/StationPartsExpansionRedux/Localization folder. If it's not there, just use the English version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext. compatibility issue relates to an external mod
Projects
None yet
Development

No branches or pull requests

4 participants