Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PFD-C Coriolis reports wrong size when deflated #142

Open
chris9871 opened this issue May 28, 2018 · 14 comments
Open

PFD-C Coriolis reports wrong size when deflated #142

chris9871 opened this issue May 28, 2018 · 14 comments

Comments

@chris9871
Copy link

The size reported when deflated for Coriolis is 3.1m (correct) x 11.8m (probably incorrect) x 5.8m (probably correct). Rotating it 45degrees results in 3.1m x 8.9m x 8.8m.

@ChrisAdderley
Copy link
Collaborator

Sorry it took me so long to get to this, does this happen with the other centrifuges? I know KSP doesn't do bounds calculations very well so there might not be much I can do about this.

@ChrisAdderley ChrisAdderley self-assigned this Jul 23, 2018
@chris9871
Copy link
Author

No, only this one. I verified that all the other ones report values pretty close to expected.

@ChrisAdderley
Copy link
Collaborator

Issue still under investigation - not sure what's wrong.

@ChrisAdderley
Copy link
Collaborator

Think I got this :)

@chris9871
Copy link
Author

Cool beans! I have, of course, long since launched my station, but I'll give it a try when it comes out!

@ChrisAdderley
Copy link
Collaborator

Fixed in 1.0.6

@chris9871
Copy link
Author

Hmm, I just tried it in 1.0.6 and I notice two things in game. 1) it still seems to report the wonky 11.8m, and 2) it looks like there's flickering graphics issues as if two images were overlaid.

I wanted to make sure that I had the right version installed so I checked the GameData/StationPartsExpansionRedux and found that the version file says 1.0.5 even though ckan says 1.0.6 (so this could just be a ckan issue).

@ChrisAdderley
Copy link
Collaborator

I found a small issue but did a deeper investigation. The real size of the part as calculated by the games does change now, but the Engineer's Report doesn't update unless you pick up and move the part (or the whole vessel or similar). This seems to occur with stock deploying parts like solar panels as well so I don't know if there's much I can do with it.

@chris9871
Copy link
Author

I noticed that as well and was taking that into account - move the object after shrinking it, then check the dimensions.

@ChrisAdderley ChrisAdderley reopened this Sep 22, 2018
@ChrisAdderley
Copy link
Collaborator

ChrisAdderley commented Sep 22, 2018

Oh, didn't notice that, looks like a completely different issue somehow then. Reading fail. Re-opened, have no idea what's wrong.

@chris9871
Copy link
Author

Ironically, the only reason I noticed it was when I tried to stick it into a Hangar (another mod).

@ChrisAdderley
Copy link
Collaborator

Yeah I'm going to have to investigate how the game generates these. They appear to be related to drag cubes, but the cubes themselves are fine (after 1.0.6 at least) so I'm a little stumped.

@chris9871
Copy link
Author

I'm not 100% certain that I was using the right version - see above. If it's a stumper, don't worry about it, the workaround are easy enough :)

@ChrisAdderley
Copy link
Collaborator

Nah I repro'ed your problem in the dev branch so it must be for sure a problem.
My actual candidate for causing the problem is the deformable mesh of the tube. KSP doesn't calculate the bounds of these correctly some of the time so it might be running into that.

I'll timebox maybe an hour more of time to investigation in the next day or two, but that's all I can commit to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants