We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ex: https://shiny.posit.co/py/api/core/ui.include_js.html app throws an error as the JS file is not in the shinylive-python chunk.
I see that there use to be code that would add the files to the shinylive chunk within quartodoc. https://github.com/posit-dev/py-shiny/pull/1029/files#diff-0f7f4e5de0ea458c581fb3281fc73413684085b64b2e6939e7782a382d9b1bfaL89-L93
I see the logic was relocated to
py-shiny/shiny/_docstring.py
Lines 326 to 328 in 17370fd
I believe the example writer is not receiving the files and the root cause is located here: https://github.com/posit-dev/py-shiny/blob/17370fdfc8f2c58070af418d05fdc6f6240c8112/shiny/_docstring.py#L155C18-L155C28 . It would possibly be fixed by using something like https://github.com/posit-dev/py-shiny-site/blob/d75ffa4105c7fa111d73d2a4ed685ec232b76a0f/_renderer.py#L76
Independently, I believe https://github.com/posit-dev/py-shiny-site/blob/d75ffa4105c7fa111d73d2a4ed685ec232b76a0f/_renderer.py should be removed. I can't see how it is being used and would like to reduce possible confusion.
The text was updated successfully, but these errors were encountered:
schloerke
Successfully merging a pull request may close this issue.
Ex: https://shiny.posit.co/py/api/core/ui.include_js.html app throws an error as the JS file is not in the shinylive-python chunk.
I see that there use to be code that would add the files to the shinylive chunk within quartodoc. https://github.com/posit-dev/py-shiny/pull/1029/files#diff-0f7f4e5de0ea458c581fb3281fc73413684085b64b2e6939e7782a382d9b1bfaL89-L93
I see the logic was relocated to
py-shiny/shiny/_docstring.py
Lines 326 to 328 in 17370fd
and https://github.com/posit-dev/py-shinylive/blob/d0696727c1fd35b374489d072a1cbf4120879cb6/shinylive/_url.py#L289
I believe the example writer is not receiving the files and the root cause is located here: https://github.com/posit-dev/py-shiny/blob/17370fdfc8f2c58070af418d05fdc6f6240c8112/shiny/_docstring.py#L155C18-L155C28 . It would possibly be fixed by using something like https://github.com/posit-dev/py-shiny-site/blob/d75ffa4105c7fa111d73d2a4ed685ec232b76a0f/_renderer.py#L76
Independently, I believe https://github.com/posit-dev/py-shiny-site/blob/d75ffa4105c7fa111d73d2a4ed685ec232b76a0f/_renderer.py should be removed. I can't see how it is being used and would like to reduce possible confusion.
The text was updated successfully, but these errors were encountered: