Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ability to cancel a deployment (for now) #2498

Open
m-- opened this issue Dec 17, 2024 · 2 comments
Open

Remove ability to cancel a deployment (for now) #2498

m-- opened this issue Dec 17, 2024 · 2 comments
Assignees
Milestone

Comments

@m--
Copy link
Collaborator

m-- commented Dec 17, 2024

We added an attempt to support cancelling deployments in progress, but we need changes on Connect to support it fully. #304 is the issue to fully support this functionality, but in the mean time we should remove what appears to be support for cancellation in Publisher (which doesn't fully work).

Removing this would solve #2179

The functionality to be removed was added within #2071, but we may not want to just roll it back. A simple cherry-picking of changes might be worth considering.

@dotNomad
Copy link
Collaborator

dotNomad commented Dec 19, 2024

Noting here that we still need the ability to dismiss an in-progress deploy, if we still disable the deploy button while something is in progress. This will prevent a regression of #2057

@dotNomad
Copy link
Collaborator

dotNomad commented Jan 7, 2025

We can look into filtering on the stream ID to see if we can ignore the deploy we are "dismissing" to avoid the regression of #2057

@dotNomad dotNomad modified the milestones: v1.8.0, v1.10.0 Jan 7, 2025
@dotNomad dotNomad marked this as a duplicate of #2179 Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants