Use icons with deployment selection details #2535
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed the |
dotNomad
force-pushed
the
dotnomad/selection-icons
branch
from
c64b82a to
8214c33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds icons next to the details in the deployment selection
QuickPickItemcomponent.Specifically:
servercodicon next to the Credential indicating the Connect Server the deployment will be going tofilecodicon next to the entrypoint file nameIf you have an alternative suggest the list of codicons can be found here: https://microsoft.github.io/vscode-codicons/dist/codicon.html
Before
After
Intent
Resolves #2483
Type of Change
Approach
The approach here was to support both strings (as we did before) and the new
IconDetailobject in theQuickPickItemdetailsprop. Now that it supports both we can easily send the newIconDetailarray to the component.Additional margin (
margin-bottom: 2px) was added to the detail rows to provide a bit more spacing between the details with the new icons.