Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a deployment fails before we can create anything on Connect, we still display an active View Content button #2373

Open
kgartland-rstudio opened this issue Oct 9, 2024 · 2 comments
Labels
bug Something isn't working discovery Additional discovery is necessary to determine a solution priority:high
Milestone

Comments

@kgartland-rstudio
Copy link
Collaborator

If I try to deploy content to Connect but it fails before anything is created, under the failure message there's still a View Content button but it leads nowhere.

Here I was able to add the dogfood server using http:// rather than https:// and deploy but that deployment didn't result in content being created. However, we still show the View Content button which doesn't lead anywhere.

Image

@kgartland-rstudio kgartland-rstudio added the bug Something isn't working label Oct 9, 2024
@sagerb
Copy link
Collaborator

sagerb commented Oct 9, 2024

Based on a file refresh or manual refresh, we will be querying the status of content on the server. We can tie into this and disable the button if not possible.

@dotNomad
Copy link
Collaborator

Rather than relying on if the deployment record is in the pre-deployment state we can use the Connect API in a similar way to #2179

@dotNomad dotNomad added this to the v1.6.0 milestone Nov 13, 2024
@dotNomad dotNomad added the discovery Additional discovery is necessary to determine a solution label Nov 13, 2024
@jonkeane jonkeane modified the milestones: v1.6.0, v.1.8.0 Nov 20, 2024
@dotNomad dotNomad modified the milestones: v1.8.0, v1.10.0 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working discovery Additional discovery is necessary to determine a solution priority:high
Projects
None yet
Development

No branches or pull requests

4 participants