RSessionManager.getConsoleSession() needs to learn about the multi-console world

[DavisVaughan]

positron/extensions/positron-r/src/session-manager.ts

Lines 150 to 181 in de61ced

	/**
	* Gets the R console session, if one is active.
	*
	* @returns The R console session, or undefined if there isn't one.
	*/
	getConsoleSession(): RSession | undefined {
	// Sort the sessions by creation time (descending)
	const sessions = Array.from(this._sessions.values());
	sessions.sort((a, b) => b.created - a.created);
	// Remove any sessions that aren't console sessions and have either
	// never started or have exited
	const consoleSessions = sessions.filter(s =>
	s.metadata.sessionMode === positron.LanguageRuntimeSessionMode.Console &&
	s.state !== positron.RuntimeState.Uninitialized &&
	s.state !== positron.RuntimeState.Exited);
	// No console sessions
	if (consoleSessions.length === 0) {
	return undefined;
	}
	// We would not expect to see more than one console session since
	// Positron currently only allows one console session per language. If
	// this constraint is relaxed in the future, we can remove this warning.
	if (consoleSessions.length > 1) {
	console.warn(`${consoleSessions.length} R console sessions found; ` +
	`returning the most recently started one.`);
	}
	return consoleSessions[0];
	}

This currently is unaware of multi-console, and will always choose the newest created R session. That means if you:

• Start R 1
• Start and switch to R 2
• Switch back to R 1

Then IIUC getConsoleSession() will pick R 2 as the console session, which is not right.