Merge pull request #479 from shanselman/main

comments aren't loaded, null check for /post/guid URLs

Author: poppastring

azure-pipelines.yml

@@ -5,8 +5,8 @@ strategy:
       imageName: 'ubuntu-18.04'
 #    mac:
 #      imageName: 'macos-10.13'
-    windows:
-      imageName: 'windows-2019'
+#    windows:
+#      imageName: 'windows-2019'
 
 pool:
   vmImage: $(imageName)

source/DasBlog.Web.UI/Controllers/BlogPostController.cs

@@ -99,8 +99,21 @@ public IActionResult PostGuid(Guid postid)
 			var entry = blogManager.GetBlogPostByGuid(postid);
 			if (entry != null)
 			{
-				lpvm.Posts = new List<PostViewModel>() { mapper.Map<PostViewModel>(entry) };
 
+				/*
+				 * Very old DasBlog links like
+				 * /PermaLink.aspx?guid=b5790285-2eb7-4198-ac1d-6cfbf20735a4
+				 * turn into 
+				 * /post/b5790285-2eb7-4198-ac1d-6cfbf20735a4 
+				 * (given correct IISrewrites)
+				 * but fails to render because the Comments are never loaded, 
+				 * so you'll get the post but it shows ZERO comments. 
+				 * Better to just redirect to the right URL
+				 * I can't figure how to redirect 302 correctly given a /blog baseURL, so for now at least it doesn't break 
+				 * and has the right canonical
+				 * 				//return RedirectToAction("Post", "BlogPost", new { title = lpvm?.Posts?.First().PermaLink });
+				 */
+				lpvm.Posts = new List<PostViewModel>() { mapper.Map<PostViewModel>(entry) };
 				return SinglePostView(lpvm);
 			}
 			else

source/DasBlog.Web.UI/Controllers/DasBlogBaseController.cs

@@ -62,7 +62,7 @@ protected void SinglePost(PostViewModel post)
 
         private void ShowErrors(PostViewModel post)
         {
-            if(post != null && post.Comments.CurrentComment != null && post.ErrorMessages != null && post.ErrorMessages.Count > 0)
+            if(post != null && post.Comments != null && post.Comments.CurrentComment != null && post.ErrorMessages != null && post.ErrorMessages.Count > 0)
             {
                 foreach(string ErrorMessage in post.ErrorMessages)
                 {