Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Bool with exhaustive match #4572

Open
SeanTAllen opened this issue Dec 17, 2024 · 0 comments
Open

Handle Bool with exhaustive match #4572

SeanTAllen opened this issue Dec 17, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@SeanTAllen
Copy link
Member

Currently, the following code isn't seen as an exhaustive match:

actor Main
	new create(env: Env) =>
	  env.out.print("Hello World")

	fun box fourty_two(err: Bool = false): USize ? =>
		match err
	  | true =>
	    return 50
	  | false =>
	    return 42
	  end

This is surprising to folks and we believe that exhaustiveness checking should be enhanced to handle this for booleans.

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Dec 17, 2024
@SeanTAllen SeanTAllen added help wanted Extra attention is needed enhancement New feature or request good first issue Good for newcomers and removed discuss during sync Should be discussed during an upcoming sync labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants