Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fitting] dependency between setWeightFunc and init #67

Open
nmellado opened this issue Oct 4, 2022 · 4 comments · May be fixed by #103
Open

[fitting] dependency between setWeightFunc and init #67

nmellado opened this issue Oct 4, 2022 · 4 comments · May be fixed by #103
Labels
bug Something isn't working

Comments

@nmellado
Copy link
Contributor

nmellado commented Oct 4, 2022

The methods

ponca/Ponca/src/Fitting/primitive.h

Line 63 in 1793b3b

PONCA_MULTIARCH inline void setWeightFunc (const WFunctor& _w) { m_w = _w; }

and

ponca/Ponca/src/Fitting/primitive.h

Lines 66 to 72 in 1793b3b

PONCA_MULTIARCH inline void init(const VectorType& _basisCenter = VectorType::Zero())
{
m_eCurrentState = UNDEFINED;
m_nbNeighbors = 0;
m_sumW = Scalar(0);
m_w.init( _basisCenter );
}

must be called in the right order to have m_w correctly initialized.

This is not documented, and other cases are not detected
@nmellado nmellado added the bug Something isn't working label Oct 4, 2022
@github-actions
Copy link

Stale issue message

@github-actions github-actions bot closed this as completed Apr 4, 2023
@nmellado nmellado reopened this Apr 4, 2023
@nmellado nmellado reopened this Apr 12, 2023
@github-actions
Copy link

Stale issue message

@nmellado nmellado linked a pull request Aug 3, 2023 that will close this issue
[Fitting] Change init API (WIP) #103
Draft
@github-actions
Copy link

Stale issue message

@github-actions
Copy link

Stale issue message

@nmellado nmellado reopened this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fitting] Change init API (WIP) poncateam/ponca
1 participant
@nmellado