-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cities to convert #22
Comments
I'll keep this table updated with data sources…
|
I had a play with the new, official NYC data and the results are promising! Unfortunately, it seems like the converter isn't working correctly for some buildings (eg. the library) but I've not put any effort in to work out what exactly is failing here but the result is that same faces are flipped. Looks like either the geometry is invalid, or the obj-conversion / repair operations are doing things they shouldn't be (like flipping faces that were actually valid to begin with). It may actually make sense to provide an option to disable validation checks and repairs as if the data is 100% valid anyway then it may produce more reliable results. |
Yes, I noticed that too but haven't had the chance to look more closely at it. I like the idea of making validation an option, though.
|
From what I can see there are a few buildings that have overlapping geometry too which causes a lot of z-fighting, so my money is on a combination of bad / invalid geometry and edge-case issues with the converter / repair system I wrote. Probably best to run it through val3dity and see what comes back. |
based on https://github.com/polygon-city/polygon-city-app/issues/48
The text was updated successfully, but these errors were encountered: