Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Karla font family to Material UI theme #1657

Open
henryk1229 opened this issue Aug 7, 2023 · 0 comments · May be fixed by #1658
Open

Add Karla font family to Material UI theme #1657

henryk1229 opened this issue Aug 7, 2023 · 0 comments · May be fixed by #1658
Labels
improvement: enhancement ✨ Improvement to existing functionality platform: react ⚛️ Related to React client application

Comments

@henryk1229
Copy link
Contributor

Is your feature request related to a problem? Please describe.
While working on #1641, @kennyycheng requested that the components use the Karla font - this is an easy change, but since it would effect every component that consumes our material ui theme, we decided the change merited a separate issue + pr (#1641 (comment))

Describe the solution you'd like
the createMuiThemeV1 function in mui-theme.ts should be updated to include a typography field, with sub-field fontFamily: 'Karla', so that the font is included in the theme.

Describe alternatives you've considered
n/a

Additional context
n/a

@henryk1229 henryk1229 self-assigned this Aug 7, 2023
@henryk1229 henryk1229 added platform: react ⚛️ Related to React client application improvement: enhancement ✨ Improvement to existing functionality labels Aug 7, 2023
@ajohn25 ajohn25 linked a pull request Aug 9, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement: enhancement ✨ Improvement to existing functionality platform: react ⚛️ Related to React client application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant