Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nalgebra support #14985

Closed
j-h-stevens opened this issue Mar 11, 2024 · 5 comments
Closed

Nalgebra support #14985

j-h-stevens opened this issue Mar 11, 2024 · 5 comments
Labels
enhancement New feature or an improvement of an existing feature

Comments

@j-h-stevens
Copy link

Description

Convert Polars DataFrame to Nalgebra's DMatrix; similar functionality as "to_ndarray".

@j-h-stevens j-h-stevens added the enhancement New feature or an improvement of an existing feature label Mar 11, 2024
@orlp
Copy link
Collaborator

orlp commented Mar 11, 2024

I don't think we want to add this at this point. You can write the conversion from ndarray to DMatrix yourself, or use a crate like https://lib.rs/crates/nshare (haven't tested it, ndarray recommends it).

@orlp orlp closed this as not planned Won't fix, can't repro, duplicate, stale Mar 11, 2024
@orlp
Copy link
Collaborator

orlp commented Mar 11, 2024

When the Rust tabular data/tensor data community agrees on an interchange format / common library we'll be more than happy to support it, but I don't feel like adding a different export and conditional compilation / features for every new matrix / tensor library under the sun.

@LockedThread
Copy link

When the Rust tabular data/tensor data community agrees on an interchange format / common library we'll be more than happy to support it, but I don't feel like adding a different export and conditional compilation / features for every new matrix / tensor library under the sun.

ndarray is having some maintainership turmoil right now. My company has moved to nalgebra because of it's vibrant community and amazing documentation.

@akern40
Copy link

akern40 commented Nov 22, 2024

@LockedThread I'm sorry to hear that ndarray wasn't fulfilling your company's needs! I'd really like to hear some more about what made you switch over, what features were missing, what documentation was needed, etc. This isn't the place to do that, but if you head to that issue you linked to (rust-ndarray/ndarray#1272) and scroll to the bottom, I'm soliciting feedback from the community. Would love to have your participation.

@LockedThread
Copy link

@LockedThread I'm sorry to hear that ndarray wasn't fulfilling your company's needs! I'd really like to hear some more about what made you switch over, what features were missing, what documentation was needed, etc. This isn't the place to do that, but if you head to that issue you linked to (rust-ndarray/ndarray#1272) and scroll to the bottom, I'm soliciting feedback from the community. Would love to have your participation.

Thank you for reaching out. I put a comment with our major reasons in the other chat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

4 participants