-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Podverse Mission Statement translatable #1926
Comments
Hi, just yesterday I updated de Spanish translation of podverse-web and I did have available that string to translate. Is the lock on the PR bot on GitHub? |
@Marzal that "Mission statement" string should be translatable and should surface in the web app. I'm not sure I understand your question? If you are wondering why the changes aren't reflected on the web site yet, I just need to release a new version of the web app. It's a very simple process with our Github Actions, so I will do that right now. Also, thank you very much for the Spanish translations! You did a lot of work there. |
@mitchdowney let me reformulate: The platform makes translation quite easy, the next time my daughter is out with her grandpa I will try to do the Mobile app strings. |
@Marzal ahh, so, the link you provided is actually for the podverse-web repo, which is for the website, but this ticket is for the mobile app, so I was confused. This text you're seeing in the screenshot could be translatable. It's more of the legal-related text I'm concerned about. I'll assign this ticket to me so I remember to make the text translatable in the mobile app. |
@Marzal this should be translatable as of 4.15.1 |
There are some instances of text in the web and mobile app that we have purposely not allowed to be translated into other languages. My primary reason for doing with this text is that I want to be extra careful and do extra review, since this text may relate to our mission statements as an organization, or have legal implications.
That said, maybe I am being overly cautious. I'm not sure how to proceed on this at the moment, but I think it would be useful to at least organize examples of the screens / pages that are not translatable at this time for those reasons.
related to: podverse/podverse-web#1185
The text was updated successfully, but these errors were encountered: